feat(google-genai): Check Google Generative AI Structured Output #7293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jacoblee93
changed the title
jacoblee93
reviewed
Dec 3, 2024
| temperature: 0.7, | ||
| }); | ||
| const structuredLlm = model.withStructuredOutput(schema); | ||
| const request = "Generate structured data where age is a number."; |
There was a problem hiding this comment.
This doesn't seem like a reliable test - shouldn't we expect an error to be thrown? Going to skip this one.
jacoblee93
reviewed
Dec 3, 2024
| expect(result.details).toHaveProperty("address"); | ||
| }); | ||
|
|
||
| test("Google AI - Handle missing required fields", async () => { |
There was a problem hiding this comment.
Same as above - this test will pass if the request doesn't throw an error.
jacoblee93
reviewed
Dec 3, 2024
| expect(result).toHaveProperty("email"); | ||
| }); | ||
|
|
||
| test("Google AI - Throw error for empty response", async () => { |
jacoblee93
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6901
This PR addresses Issue #6901, which occurred when attempting to generate structured output using Google's Generative AI. The initial fix for this issue was implemented in PR #7213, and this PR extends the coverage by adding dedicated test cases to ensure the fix's correctness and stability.